pgsql-server: > Please find enclose a submission to

pgsql-server: > Please find enclose a submission to

Post by pgma » Sun, 22 Aug 2004 06:23:11



It has been around for a while and added to the queue days ago. I don't
want to get into the habit of requiring approval from certain developers
for patch application.

Peter has replied to previous patches so I assume he would have
commented on this one if he didn't like it. It was already adjusted to
take Peter's comments into account.

--
Bruce Momjian | http://www.yqcomputer.com/
XXXX@XXXXX.COM | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings
 
 
 

pgsql-server: > Please find enclose a submission to

Post by pgma » Sun, 22 Aug 2004 09:12:53


OK, Peter, you want to look at that patch?

--
Bruce Momjian | http://www.yqcomputer.com/
XXXX@XXXXX.COM | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to XXXX@XXXXX.COM )

 
 
 

pgsql-server: > Please find enclose a submission to

Post by peter_ » Tue, 31 Aug 2004 01:24:39


I've said several times before that I did not particularly like the
functionality added by that patch (building non-server modules, and
building contrib modules outside the normal build system). Therefore,
I didn't put it high in the to-look-at queue. It might help if someone
else would comment on whether we want this.

--
Peter Eisentraut
http://www.yqcomputer.com/ ~petere/


---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings
 
 
 

pgsql-server: > Please find enclose a submission to

Post by pgma » Tue, 31 Aug 2004 02:40:39


I think making contrib buildable is a nice goal and it seems it was
rather easy to do.

--
Bruce Momjian | http://www.yqcomputer.com/
XXXX@XXXXX.COM | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend
 
 
 

pgsql-server: > Please find enclose a submission to

Post by tgl » Tue, 31 Aug 2004 13:53:09

Peter Eisentraut < XXXX@XXXXX.COM > writes:

Well, I think it's important to be able to build both server-side and
client-side modules without access to the original build tree. In an
RPM-style environment you should only need the files installed by the
"foo-devel" RPM to build packages that depend on package foo. We are
clearly not there as of current releases, and I was hoping that pgxs
would fix this.

As for contrib in particular, it is not *necessary* to be able to build
the contrib tree outside the original build tree --- but if we don't
support that then we don't have an easy part-of-the-distro way to test
that the pgxs functionality really works. So I think it makes sense to
be able to do that. I am not any keener than you on this particular
approach ... the nesting of ifdefs in the makefiles seems mighty ugly.
But I'd like to find a way to clean it up, not just claim that we don't
need to do it.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to XXXX@XXXXX.COM