[PATCH 4/5] drivers/pci/pci.c Section mismatch

[PATCH 4/5] drivers/pci/pci.c Section mismatch

Post by UmVuw6kgQm » Sat, 20 Mar 2010 09:20:02



>>>>> Signed-off-by: Rene Bolldor<< XXXX@XXXXX.COM >> >>>>> >>>>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c >>>>> index ddd55dc..a1f7d93 100644 >>>>> --- a/drivers/pci/pci.c >>>>> +++ b/drivers/pci/pci.c >>>>> @@ -2773,7 +2773,7 @@ int pci_resource_bar(struct pci_dev *dev, int >>>>> resno, enum pci_bar_type *type) >>>>> /* Some architectures require additional programming to enable VGA */ >>>>> static arch_set_vga_state_t arch_set_vga_state; >>>>> >>>>> -void __init pci_register_set_vga_state(arch_set_vga_state_t func) >>>>> +void pci_register_set_vga_state(arch_set_vga_state_t func) >>>>> { >>>>> arch_set_vga_state = func; /* NULL disables */ >>>>> } >>>>> -- >>>> >>>> Hi, >>>> >>>> Please put the offending/warning messages in the patch description. >>>> Include your analysis if it isn't obvious. >>>> >>>> thanks, >>> >>> Hi, >>> >>> the warning message was: >>> WARNING: drivers/pci/built-in.o(__ksymtab+0x190): Section mismatch in >>> reference from the variable __ksymtab_pci_register_set_vga_state to the >>> function .init.text:pci_register_set_vga_state() >>> The symbol pci_register_set_vga_state is exported and annotated __init >>> Fix this by removing the __init annotation of pci_register_set_vga_state >>> or drop the export. >>> >>> $fgrep "pci_register_set_vga_state" `find .` >>> >>> $./arch/x86/kernel/apic/x2apic_uv_x.c: >>> pci_register_set_vga_state(uv_set_vga_state); >>> $./include/linux/pci.h:extern void >>> pci_register_set_vga_state(arch_set_vga_state_t func); >>> $./drivers/pci/pci.c:void >>> pci_register_set_vga_state(arch_set_vga_state_t func) >>> $./drivers/pci/pci.c:EXPORT_SYMBOL(pci_register_set_vga_state); >>> >>> this is a volatile function that set's a spec. state and is only used >>> from uv_system_init(arch/x86/kernel/apic/x2apic_uv_x.c), the macro can >>> also be removed. >> >> Thanks. Yes, we shouldn't export __init functions, so the patch makes >> sense. >> >> BTW, you need to cc: one or more maintainers so that someone will merge >> your patches. They don't scan the mailing lists looking for patches to merge. >> >>

Added Cc.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

1. [PATCH 1/7]: PCI revised [PATCH 16/42]: PCI: PCI Error reporting callbacks

2. [PATCH 1/7]: PCI revised (2) [PATCH 16/42]: PCI: PCI Error reporting callbacks


Closer but...


You don't have to use an enum anymore, just use a #define.

Sparse developers, I see code in the kernel that that does both
(__force foo_t) and (foo_t __force). Which one is correct?



Ugh, I don't like that name, but I can't think of anything better right
now. You should at least keep "pci" at the beginning to make it make
more sense to people looking at it for the first time.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

3. [PATCH 1/7]: PCI revised (2) [PATCH 16/42]: PCI: PCI Error reporting callbacks

4. [PATCH 1/7]: PCI revised [PATCH 16/42]: PCI: PCI Error reporting callbacks

5. [PATCH] PCI: make drivers use the pci shutdown callback instead of the driver core callback.

6. [PATCH 2.6.11-rc2 05/29] ide: merge pci driver .h's into .c's

7. Driver and PCI, PCI-X and PCI Express

8. [PATCH] PCI: add linux-pci mailing list to PCI maintainers entry.

9. [v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

10. [PATCH] PCI Hotplug: PCI panic on dlpar add (add pci slot to running partition)

11. [PATCH] PCI: handle subtractive decode pci-pci bridge better

12. [PATCH 1/2] PCI-PCI transparent bridge handling improvements (pci core)

13. [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

14. [RFC: 2.6 patch] drivers/pci/pci.c: remove pci_dac_set_dma_mask

15. PCI Power management (was: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery