[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

Post by Mike Frysi » Wed, 16 Sep 2009 20:20:06



i dont think i have any adp5588 hardware. Robin: do we have any in
Norwood ? otherwise, it'll have to wait for Michael to get back to
double check.


yes, after your suggestion for the previous driver, we've been looking
at all our input drivers to convert to threaded IRQs. do we need to
convert all of them before acceptance, or can we merge now and post an
updated patch after ?
-mike
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

Post by Mike Frysi » Thu, 17 Sep 2009 01:50:07


i dont think there is a race here as we only use the IRQ to schedule
the WQ; we dont read/pass info between the two.

at any rate, i noticed that this driver isnt the final one. i spent
some time cleaning it up a bit more (style, messages, dev_pm_ops), so
i'll merge your changes and mine and post another one.
-mike
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

Post by Barry Son » Thu, 17 Sep 2009 13:00:09

On Wed, Sep 16, 2009 at 12:26 AM, Dmitry Torokhov




Even though CONFIG_GENERIC_HARDIRQS is almost always "y", in case
CONFIG_GENERIC_HARDIRQS is "n" not "y", threaded_irq will become
original irq, drivers will not work. So is it necessary to check the
dependence of GENERIC_HARDIRQS while using threaded_irq?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

Post by Mike Frysi » Thu, 17 Sep 2009 13:10:05


when is GENERIC_HARDIRQS not "y" ? a quick check shows only s390/m68k
dont set it to "y" in their arch Kconfig ? s390 isnt going to use any
of these drivers, and m68k will eventually update (m68knommu already
has !?).
-mike
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/