[PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

[PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

Post by Paul Jacks » Fri, 03 Mar 2006 23:30:15


> Seems pointless. This just increases #ifdef churn for no gain.

Take a look at fs/proc/base.c. That's how pretty much all the
other proc hooks are done, with ifdef's around their proc hooks.

ifdef minimization is a good goal, yes.

But uniformity of practice is another good goal.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson < XXXX@XXXXX.COM > 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

Post by ebieder » Sat, 04 Mar 2006 01:40:09

Paul Jackson < XXXX@XXXXX.COM > writes:


Agreed. However the direction I am gradually moving fs/proc/base.c
is the opposite. Moving things out of it as much as is reasonably
possible.

I already moved out all of the /proc/<pid>/?maps code into
fs/proc/task_mmu.c

I think the more important piece of uniform practice is to put all of
the operations structures and methods together in one file so that it
is easier to look between them, when making modifications especially
since cpuset_open and proc_cpuset_show are interdependent.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

[PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

Post by Paul Jacks » Sat, 04 Mar 2006 02:01:15

> Agreed. However the direction I am gradually moving fs/proc/base.c

Oh - ok fine.

I had seen something from Andrew a couple of days ago
that led me to a different understanding in this particular
case.

Andrew - kill this patch (unless you know better.)

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson < XXXX@XXXXX.COM > 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c

Post by ebieder » Sat, 04 Mar 2006 02:30:35

Paul Jackson < XXXX@XXXXX.COM > writes:


As we increase the number of namespaces that we allow multiple instances
of in linux. More of the files that are in /proc need to become
per process, like /proc/mounts did.

I mentioned that to Andrew and I think the message got a little
garbled.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/