[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

Post by Dmitry Tor » Thu, 17 Sep 2009 01:30:17



> >> + struct adp5588_kpad *kpad = dev_get_drvdata(&clien>->dev);> >>>> +> >>>> + adp5588_write(client, CFG, 0>;>>> >> + free_irq(c>ient->irq, kp>d>; >>>>
> > cancel_work_sync() is missing. Could you try the updated version be>ow?> >
> i dont think i have any adp5588 hardware. Robin: do we have an> in
> Norwood ? otherwise, it'll have to wait for Michael to get bac> to
> double ch>ck.> >
> > BTW, maybe you shoudl convert to threaded IRQs h>re?> >
> yes, after your suggestion for the previous driver, we've been loo>ing
> at all our input drivers to convert to threaded IRQs. do we nee> to
> convert all of them before acceptance, or can we merge now and pos> an
> updated patch after ?

It really depends on the driver. If there is a race between IRQ and the
WQ in the driver I will request you to fix it one way or another before
accepting the driver (and quite often using threaded IRQ gets rid of the
race). In the cases like this particular driver though I am not even
convinced that we need threaded IRQ. The driver is not expected to
generate lots of events rapidly so using keventd as it does now is
probably the best solution.

--
Dmitry
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver

Post by Dmitry Tor » Thu, 17 Sep 2009 02:20:07


> >> >> + struct adp5588_kpad *kpad = dev_get_drvdata(&clien>->dev);> >>>>>>> +> >>>>>>> + adp5588_write(client, CFG, 0>;>>>>>> >> + free_irq(c>ient->irq, kp>d>> >> >>>> >> >> > cancel_work_sync() is missing. Could you try the updated version be>o>>
> >> i dont think i have any adp5588 hardware. obin: do we have an> >>
> >> Norwood ? therwise, it'll have to wait for Michael to get bac> >>
> >> double ch>c>>
> >> yes, after your suggestion for the previous driver, we've been loo>i>>
> >> at all our input drivers to convert to threaded IRQs. o we nee> >>
> >> convert all of them before acceptance, or can we merge now and pos> >>
> >> updated patch aft>r>? >>>>
> > It really depends on the driver. If there is a race between IRQ and>t>e
> > WQ in the driver I will request you to fix it one way or another be>o>e
> > accepting the driver (and quite often using threaded IRQ gets rid of>t>e
> > race). In the cases like this particular driver though I am not >v>n
> > convinced that we need threaded IRQ. The driver is not expecte> >o
> > generate lots of events rapidly so using keventd as it does no> >s
> > probably the best solut>on.> >
> i dont think there is a race here as we only use the IRQ to sche>ule
> the WQ; we dont read/pass info between the >wo.
>

Right, that's what I was trying to say - there is no race in
thisparticular drive>.

> at any rate, i noticed that this driver isnt the final one. i s>ent
> some time cleaning it up a bit more (style, messages, dev_pm_ops)> so
> i'll merge your changes and mine and post another one.

OK, great.

--
Dmitry
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/