Developer Forum

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Off the cuff, this doesn't look bad... tho it does a lot.

The reordering of locking in device_reset and bus reset definately looks
good, especially for the corner-cases (yanked device, etc.).

I'm uncertain if your handling of the io_request_lock is right.... but
getting information on how to handle that has been like pulling teeth, so
I'm inclined to trust your wide-scale testing on this.

Was there a reason to add more do-nothing code to host_reset?

Is it really safe to remove the irq_urb_sem?

Also, please make sure everything is CC'ed to the usb-storage list (on this
message).

Matt

On Fri, Apr 09, 2004 at 07:59:43PM -0700, Pete Zaitcev wrote:

--
Matthew Dharm Home: XXXX@XXXXX.COM
Maintainer, Linux USB Mass Storage Driver

Department of Justice agent. I have come to purify the flock.
-- DOJ agent
User Friendly, 5/22/1998

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFAeIzVIjReC7bSPZARAnGlAJ9m5C8n1yrKAePw/pZFjuY5Hd5xaQCgkW3W
XSNkat9/saEuANMDypPBAkU=
=sv+9
-----END PGP SIGNATURE-----