[PATCH] Fix hotplug cpu on ppc64

[PATCH] Fix hotplug cpu on ppc64

Post by Zwane Mwai » Wed, 22 Dec 2004 04:20:10


I seem to have broken this when i moved the clearing of the dying cpu to
arch specific code.

Signed-off-by: Zwane Mwaikambo < XXXX@XXXXX.COM >

Index: linux-2.6.10-rc3-mm1/arch/ppc64/kernel/pSeries_smp.c
===================================================================
RCS file: /home/cvsroot/linux-2.6.10-rc3-mm1/arch/ppc64/kernel/pSeries_smp.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 pSeries_smp.c
--- linux-2.6.10-rc3-mm1/arch/ppc64/kernel/pSeries_smp.c 13 Dec 2004 14:26:53 -0000 1.1.1.1
+++ linux-2.6.10-rc3-mm1/arch/ppc64/kernel/pSeries_smp.c 20 Dec 2004 19:12:02 -0000
@@ -92,11 +92,13 @@ int __cpu_disable(void)
{
/* FIXME: go put this in a header somewhere */
extern void xics_migrate_irqs_away(void);
+ int cpu = smp_processor_id();

+ cpu_clear(cpu, cpu_online_map);
systemcfg->processorCount--;

/*fix boot_cpuid here*/
- if (smp_processor_id() == boot_cpuid)
+ if (cpu == boot_cpuid)
boot_cpuid = any_online_cpu(cpu_online_map);

/* FIXME: abstract this to not be platform specific later on */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

1. [PATCH 2/2] Hotplug CPU vs TASK_ZOMBIEs: The Sequel to Hotplug CPU vs TASK_DEAD

2. [PATCH] ppc64 gives up too quickly on hotplugged cpu

This is a multi-part message in MIME format.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
Hi-

On some systems it can take a hotplugged cpu much longer to come up than
it would at boot. If the cpu comes up after we've given up on it, it
tends to die in its first attempt to kmem_cache_alloc (uninitialized
percpu data, I imagine).

In my experimentation I haven't seen a processor take more than one
second to become available; the patch waits five seconds just to be safe.

Patch is against 2.6.7-rc2; please apply.

Signed-off-by: Nathan *** < XXXX@XXXXX.COM >

3. [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation

4. [PATCH 2/2] Hotplug CPU vs TASK_ZOMBIEs: The Sequel to Hotplug CPU vs TASK_DEAD

5. [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation

6. [patch] slab: Fix a cpu hotplug race condition while tuning slab cpu caches

7. [patch] slab: Fix a cpu hotplug race condition while tuning slab cpu caches

8. + cpu-hotplug-fix-locking-in-cpufreq-drivers-fix.patch added to -mm tree

9. [RFC][PATCH] ia64 node hotplug -- cpu - node relationship fix [1/2] empty node fix

10. [patch 3/3] NUMA slab locking fixes -- slab cpu hotplug fix

11. various cpu patches [was: (resend) take3: Updated CPU Hotplug patches]

12. various cpu patches [was: (resend) take3: Updated CPU Hotplug patches]

13. [PATCH] PPC64 (1/3) Rework PPC64 cpu map setup

14. [PATCH] PPC64 Fix idle loop for offline cpu

15. [PATCH] PPC64 sparse fixes for cpu feature constants