[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Alan Ster » Thu, 16 Aug 2007 23:40:14



I think we can simply remove the error message. There's no obvious
reason why sysfs_remove_bin_file() should complain about attempts to
remove a nonexistent file; sysfs_remove_file() doesn't.

This patch will get rid of the annoying error messages. It won't do
anything about your keyboard's tendency to spontaneously stop working,
alas.

Alan Stern


Index: usb-2.6/fs/sysfs/bin.c
===================================================================
--- usb-2.6.orig/fs/sysfs/bin.c
+++ usb-2.6/fs/sysfs/bin.c
@@ -248,12 +248,7 @@ int sysfs_create_bin_file(struct kobject

void sysfs_remove_bin_file(struct kobject * kobj, struct bin_attribute * attr)
{
- if (sysfs_hash_and_remove(kobj->sd, attr->attr.name) < 0) {
- printk(KERN_ERR "%s: "
- "bad dentry or inode or no such file: \"%s\"\n",
- __FUNCTION__, attr->attr.name);
- dump_stack();
- }
+ sysfs_hash_and_remove(kobj->sd, attr->attr.name);
}

EXPORT_SYMBOL_GPL(sysfs_create_bin_file);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Jiri Kosin » Fri, 17 Aug 2007 00:00:17


It is not immediately clear what might be causing this, 2.6.23-rc3 didn't
get any USB nor HID updates at all compared to 2.6.23-rc2.

Could you please enable USB and HID debugging to see whether we can see
anything spurious in the logs at the time the keyboard gets stuck?

Bisecting this might be a bit painful if it is not reproducible in
predictable timeframes :(

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Jiri Kosin » Fri, 17 Aug 2007 00:00:19


The error message seems unrelated to your keyboard becoming dead.


Is that reproducible, or did it happen just once? Any error message
present in log prior to that sysfs dump please?

Thanks,

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Cornelia H » Fri, 17 Aug 2007 00:30:15

On Wed, 15 Aug 2007 23:54:43 +0900,




Three comments:

- Randy made sysfs_remove_bin_file() return void in commit
995982ca79d9262869513948ec7c540f32035491.

- For symmetry reasons, sysfs_remove_file() should then also pass the
return value on.

- I'm not sure who wants to care whether they removed an existing or
non-existing file. But maybe I'm just unimaginative.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Alan Ster » Fri, 17 Aug 2007 00:30:17


It wasn't an oops, just a warning.


To track this down, you might try building 2.6.23-rc3 with
CONFIG_USB_DEBUG enabled. Then retrieve the dmesg log after the
keyboard stops working and post it. You probably ought to CC: the
maintainer of the HID core layer as well (and you can trim the existing
CC: list).

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Alan Ster » Fri, 17 Aug 2007 00:40:06


Perhaps. But none of

sysfs_remove_one()
sysfs_remove_subdir()
sysfs_remove_dir()
sysfs_remove_file()
sysfs_remove_file_from_group()
sysfs_remove_group()
sysfs_remove_link()

return a value. Why should sysfs_remove_bin_file() be different? And
what callers would pay attention to the return value?

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Jiri Kosin » Wed, 22 Aug 2007 21:10:10


I guess that this is the card reader being suspended and resumed
afterwards. Do you by any chance see any improvement when you

- rmmod ehci_hcd
- disable USB_AUTOSUSPEND

please? Thanks,

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Jiri Kosin » Wed, 22 Aug 2007 22:10:08


Thanks. If this doesn't give us any hint, it would be useful if you could
do git-bisect between rc2 and rc3, I really can't immediately see anything
in the list of commits that might directly cause the behavior you are
seeing (most importantly because there were no USB and no HID updates in
this window).

There are approximately 290 commits, so it shouldn't require more than 9
reboots plus the time needed to check whether the bug triggers or not.

Thanks,

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Jiri Kosin » Wed, 22 Aug 2007 22:50:10


Yes, there were some NFS updates in between -rc2 and
28e8351ac22de25034e048c680014ad824323c65. I'd be now even more curious
what are you going to find by bisect, please let us know.

I added Trond to CC, full thread to be found at
http://www.yqcomputer.com/

Florin, it also might be useful to capture the states of stuck processess
via alt-sysrq-T (or better by echo t > /proc/sysrq-trigger), so that we
know better where are they stuck.

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Post by Alan Ster » Thu, 23 Aug 2007 00:00:15


FYI, the card reader suspend/resume problem should be fixed by this
patch:

http://www.yqcomputer.com/

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/