[PATCH] DMA: TXx9 Soc DMA Controller driver (v2)

[PATCH] DMA: TXx9 Soc DMA Controller driver (v2)

Post by Dan Willia » Mon, 20 Apr 2009 05:10:07



Not quite "ackable" yet...


There seems to be a lot of ifdef magic in the code based on these
defines. Can we move this magic and some of the pure definitions to
drivers/dma/txx9dmac.h? (See the "#ifdefs are ugly" section of
Documentation/SubmittingPatches)

> + i> (!first) {
> + > first = des>;
> + } else {
> + > d>sc_write_CHAR(dc, prev, desc->txd.phys);
> + gt;> dma_sync_single_for_device>chan2parent(&dc>>chan),
> > >rev->txd.phys, ddev->descsize,
> > gt;DMA>TO_DEVICE);
> > list_add_tail(&desc->desc_node,
> + &first->txd.tx_list);
> + }

Is there a reason to keep f'irst' off of the tx_list? It seems like
you could simplify this logic and get rid of the scary looking
list_spli>e followed by list_add in txx9dmac_desc_put. It also seems
odd that the descriptors on tx_list are not reachable from the
dc->queue list after a submit... but maybe I am missing a subtle
detail?

Regards,
Dan
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/