ADI Blackfin patch for kernel 2.6.14

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Wed, 02 Nov 2005 18:30:12


Hi all,

This is the new Blackfin patch for kernel 2.6.14. Mainly includes
arch/Blackfin and include/asm-blackfin files. We decided not to put in
all the drivers for this version.

Here is the patch URL:
http://www.yqcomputer.com/
. Please reiview and merge it into the kernel. Thank you very much.

Luke Yang
XXXX@XXXXX.COM
ADI Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Adrian Bun » Thu, 03 Nov 2005 03:20:28


Hi,


some comments:
- the changes to the toplevel Makefile should go to
arch/blackfin/kernel/Makefile
- please use drivers/Kconfig
- include/asm-blackfin/pci.h contains some ^M characters
- please replace "extern inline" and "extern __inline__" with
"static inline"
- CONFIG_CLEAN_COMPILE=n is not a good choice for a defconfig


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Thu, 03 Nov 2005 16:10:09

Hi,

Thank you for your reivew. I change those files and updated the patch:

http://www.yqcomputer.com/

Regards,
Luke




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Sat, 05 Nov 2005 14:10:07

Hi,

Does this patch has the chance to be merged? Is anyone reivewing or
merging it? Anything I can help? Just want to make sure... Thanks a
lot!

Luke Yang




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Greg K » Sun, 06 Nov 2005 08:10:15


Your patch is 43 thousand lines long. Please break it up into the
different logical chunks, and document them, and add a signed-off-by:
line, and send them to the proper places/people, as it is documented in
the file, Documentation/SubmittingPatches.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Tue, 08 Nov 2005 16:00:14


But this patch only includes the arch files for Blackfin. Do I have
to break it into smaller chunks? It is hard to break it...



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Greg K » Wed, 09 Nov 2005 02:20:14


A: http://www.yqcomputer.com/
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?




Is there some reason this patch should not follow the documented
process? Do you want it to be reviewed by people? Accepted into the
main kernel tree? If so, I suggest you do the proper thing.

If you have questions as to the specific ways to do this, please let us
know.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Andrew Mor » Wed, 09 Nov 2005 17:00:18

reg KH < XXXX@XXXXX.COM > wrote:

We've taken arch patches in a single hit before. It's not such a bad thing.

A basic requirement should be "it should all compile before and after the
patch". That's pretty hard to do in this case if it's split up.

That being said, a 1.6MB patch is a bit hard to review, mainly because it
doesn't fit through the email server.

From a quick look:


DEFINE_SPIN_LOCK()


Remove the `= 0'

+/*
+ * Initial task structure.
+ *
+ * All other task structs will be allocated on slabs in fork.c
+ */
+__asm__(".align 4");
+struct task_struct init_task = INIT_TASK(init_task);

weird. That align will probably go into .text, rather than where you want
it. Use __attribute__((__aligned__(4))) or ____cacheline_aligned, or just
remove it - the compiler will align this guy on a 4-byte boundary anyway.


Does this architecture support SMP? I see it's BROKEN_ON_SMP, but there
seems to be some smp-style stuff in there.


One concern when adding a new architecture is: will it be maintained
long-term? We don't want to merge an arch and then have it bitrot. Who is
behind this port, and how do we know that they'll still be around and doing
things in two years' time?


Can this arch use the generic IRQ handling code in kernel/irq/?


The idle routines don't appear to be up-to-date wrt post-2.6.14 changes.
Or if they are, they won't be after I merge Nick's stuff ;)


get_reg() is way too big to be inlined.

Ditto put_reg().


Can this arch use the generic lib/semaphore-sleepers.c?


extern decls should always go in header files. If things like
icache_init() aren't in any headers, well mutter. It'd be nice to fix
that. Involves touching all architectures, yeah, not your job...


touch_l1_data() can have static scope. Please review all global symbols
for this.


Does a new arch need to support old_mmap()?


old_select()?



More extern-decls-in-c-files


Whoa, that's a syscall I never expected to see. What's it do? Shouldn't
it be using get_user() and put_user()? Or will this forever be a nommu
arch?


What _is_ a bluefin, anyway?


Are precompiled cross-complers/assemblers available anywhere?


bix:/home/akpm> grep volatile bfin_r2_4kernel-2.6.14.patch | wc -l
2901

Cow. You know that volatile in-kernel is basically always wrong?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Sat, 12 Nov 2005 20:30:15

gt;

It doesn't support SMP now.


I don't clearly know the process of maintaining an arch in kernel.
But I am sure we can follow the right process. My question is: How do
they maintain the m68knommu arch? I think it need the uclinux patch to
run on real platfrom. What is the process like?


Yes.


Yes, please visit blackfin.uclinux.org to get our toolchain.

To the other detail questions/issues, I'll write to you soon.
Thank you for your help.

Luke Yang
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Andrey Vol » Sun, 13 Nov 2005 21:00:13


Wrong, how about dual core BF56x subfamily? It's true SMP beast.
Or you are try to told that "current SOFTWARE arch doesn't
support it yet", am I right?

Also, returning to previous posts, ALL BF5xx have normal
MMU (which possible not so useful for DSP tasks).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Greg K » Mon, 14 Nov 2005 08:00:23


The process is like maintaining any other part of the kernel:
- Try to make sure it works on all releases (harder to do with a full
arch, I know, but not impossible.)
- keep it up to date with bugfixes and the such
- be responsive to questions from other developers
- accept patches from others and intregrate them into the mainline
version in a reasonable ammount of time.

Does this arch have corporate support behind it to maintain it over
time, or is something you are going to do in your spare time (which is
fine, just curious.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Bernd Schm » Mon, 14 Nov 2005 23:30:23


The port is developed by a dedicated team at Analog Devices. For a
summary of what we're doing, see this message from an earlier thread:
http://www.yqcomputer.com/
(The reasone we're all not posting from analog.com email addresses is
that doing so would involve the use of outlook :-)


Bernd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Tue, 15 Nov 2005 16:30:11


Yes, BF56x does have two cores in one chip. But we are not going to
make it a SMP system. The second core is going to be used as a pure
DSP, do some encode/decode work. Remember Blackfin itself is a DSP
anyway.


Actually current BF5xx DSPs don't have a real MMU. It runs uClinux.
The called "MMU" in the mannual is only a cache management and memory
protect unit, not a virtual memory unit.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Luke Yan » Tue, 15 Nov 2005 16:40:07


Does this include all the rc releases? and the 2.6.14.x releases?


So the process is: when kernel release a new version, we should
update our arch related files to the new kernel, then send you the
patch. Am I right?


No problem. We have a website(blackfin.uclinux.org) and a forum.


I totally understand.


Blackfin is one of the main DSP products of ADI. ADI has a growing
team supporting. I am one of the members.

regards,
Luke Yang
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

ADI Blackfin patch for kernel 2.6.14

Post by Arjan van » Tue, 15 Nov 2005 17:00:24


well the idea is that you fix things BEFORE the kernel is released for
final, so that the final releases work out of the box (well out of
kernel.org). This implies that you sort of track the git tree on a
regular basis, but at minimum look at the first -rc kernel.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/