[patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems

[patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems

Post by Ingo Molna » Fri, 13 Jul 2007 21:50:12


From: Ingo Molnar < XXXX@XXXXX.COM >
Subject: [patch] net/input: fix net/rfkill/rfkill-input.c bug on 64-bit systems

this recent commit:

commit cf4328cd949c2086091c62c5685f1580fe9b55e4
Author: Ivo van Doorn < XXXX@XXXXX.COM >
Date: Mon May 7 00:34:20 2007 -0700

[NET]: rfkill: add support for input key to control wireless radio

added this 64-bit bug:

....
unsigned int flags;

spin_lock_irqsave(&task->lock, flags);
....

irq 'flags' must be unsigned long, not unsigned int. The -rt tree has
strict checks about this on 64-bit so this triggered a build failure.

For -stable too i suspect.

Signed-off-by: Ingo Molnar < XXXX@XXXXX.COM >

Index: linux-rt.q/net/rfkill/rfkill-input.c
===================================================================
--- linux-rt.q.orig/net/rfkill/rfkill-input.c
+++ linux-rt.q/net/rfkill/rfkill-input.c
@@ -55,7 +55,7 @@ static void rfkill_task_handler(struct w

static void rfkill_schedule_toggle(struct rfkill_task *task)
{
- unsigned int flags;
+ unsigned long flags;

spin_lock_irqsave(&task->lock, flags);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

1. [PATCH] rfkill: Regulator consumer driver for rfkill

2. New net inputs = Old net inputs + new col which is output of old net.

This is most likely nonsense.... but:

Build and train a net.
Create a new input column consisting of the predictions (single ouput
net) of the old net.
Train and get the results from the new net.

I was thinking that if you are trying to predict the sin(x) and you
have 1 input column, you get a "1 interval" lag. So you add the
ubiquitous "lag" column.

Interesting, this lag column is exactly what the output of the old net
is. Is this a coincidence or did this feedback give the net what it
needed?

Does this new column tell the new net what its error is going to be, so
it corrects.

I'm sure this has been done before. Is there a name for it?

3. [PATCH][2.6.0-test9] fix 32/64 bits for input events

4. [PATCH 0/4] wimax: Kbuild / rfkill-build / PM fixes (v3)

5. [PATCH] net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

6. [PATCH] net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

7. [PATCH 2/6]net:socket timestamp 32 bit handler for 64 bit kernel

8. [PATCH 1/6]net:Allow 32 bit socket ioctl in 64 bit kernel

9. [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1)

10. [PATCH]: Fix hrtimer hotplug cpu notifier bug on 64-bit.

11. [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel

12. [PATCH] acpi: fix 64-bit pointer truncation bugs

13. [PATCH/RFC 2.6] NET: 64-bit network statistics

14. [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1)

15. [PATCH] Fix 32/64-bit bug in ext3