[PATCH] MAINTAINERS: new kbuild maintainer

[PATCH] MAINTAINERS: new kbuild maintainer

Post by Arkadiusz » Thu, 10 Dec 2009 00:20:01



Maybe we can get colors back in menuconfig then? ;-)
http://www.yqcomputer.com/

--
Arkadiusz Mikiewicz PLD/Linux Team
arekm / maven.pl http://www.yqcomputer.com/
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] MAINTAINERS: new kbuild maintainer

Post by Arkadiusz » Thu, 10 Dec 2009 05:10:01


Yes, it does happen, I have non-color menus. That's because nconfig also mixes
wide ncurses library with non wide ncurses headers.

gcc -Wp,-MD,scripts/kconfig/.nconf.o.d -Wall -Wmissing-prototypes -Wstrict-
prototypes -O2 -fomit-frame-pointer -I/usr/include/ncurses -
DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/nconf.o
scripts/kconfig/nconf.c

/usr/include/ncurses is non wide version of ncurses headers (but on other
distros it could be done differently aka /usr/include/ncures being wide
version)

gcc -o scripts/kconfig/nconf scripts/kconfig/nconf.o
scripts/kconfig/zconf.tab.o scripts/kconfig/nconf.gui.o -lncursesw -lmenu -
lpanel -lncurses

and here it's linked to non wide version of library (also to wide, too due to
scripts/kconfig/lxdialog/check-lxdialog.sh putting it here)

Anyway way to solve this is:
- detect if ncurses header is wide or non-wide
- link with proper ncurses library based on detected header


--
Arkadiusz Mikiewicz PLD/Linux Team
arekm / maven.pl http://www.yqcomputer.com/
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

[PATCH] MAINTAINERS: new kbuild maintainer

Post by Arkadiusz » Thu, 10 Dec 2009 05:40:02


PLD/Linux


--
Arkadiusz Mikiewicz PLD/Linux Team
arekm / maven.pl http://www.yqcomputer.com/
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] MAINTAINERS: new kbuild maintainer

Post by Nir Tzacha » Thu, 10 Dec 2009 15:30:01

ello.

On Tue, Dec 8, 2009 at 10:24 PM, Michal Marek < XXXX@XXXXX.COM > wrote:
>> scripts/kconfig/nconf.>> >>> >> /usr/include/ncurses is non wide version of ncurses headers (but on othe>> >> distros it could be done differently aka /usr/include/ncures being wid>> >> version>> >>> >> gcc o scripts/kconfig/nconf scripts/kconfig/ncon>>o
>> scripts/kconfig/zconf.tab.o scripts/kconfig/nconf.gui.o -lncursesw -lmen>>-
>> lpanel -lncur>>s >>>
>> and here it's linked to non wide version of library (also to wide, too due>>o
>> scripts/kconfig/lxdialog/check-lxdialog.sh putting it he>>) >>>
>> Anyway way to solve this >>:
>> - detect if ncurses header is wide or non-w>>e
>> - link with proper ncurses library based on detected hea>er> >
> Nir, you surely know ncurses better than me :). Could you look i>to
> this? Arkadiusz, which distribution are you us>ng>
>
> Mi>hal
>

Well, I see the problem, but it does not manifest on my machines.
The thing is that lxdialog/check-lxdialog.sh always adds ncursesw to
the library path, even if the narrow version exists. I believe this is
set so that if there is only an installation of ncursesw everything
will work fine. However, it does not take into account that on most
systems (at least those I have seen) both of the versions are
installed.

As nconfig does not use any wide version function, and I believe
lxdialog does not also, I think we can remove ncursesw from the
libraries.

Arkadiusz, do the patch below help?

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
b/scripts/kconfig/lxdialog/check-lxdialog.sh
index fcef0f5..5596d0c 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -5,7 +5,7 @@
ldflags()
{
for ext in so a dylib ; do
- for lib in ncursesw ncurses curses ; do
+ for lib in ncurses curses ; do
$cc -print-file-name=lib${lib}.${ext} | grep -q /
if [ $? -eq 0 ]; then
echo "-l${lib}"


Moreover, currently nconfig does not use this check. It should be made
common to both mconf and nconf, and we need to make sure adding the
appropriate libraries only to the targets which need them (currently,
-lncurses is added to all targets in scripts/kbuild ...) Below is a
very hackish patch which does this. However, having a proper Makefile
for lxdialog would be much better.

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 6d69c7c..e0c7714 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -23,6 +23,9 @@ menuconfig: $(obj)/mconf
config: $(obj)/con<
$< $(Kconfig)

+nconfig: $(obj)/ncon<
+ $< $(Kconfig)
+
oldconfig: $(obj)/con<
$< -o $(Kconfig)

@@ -109,6 +112,7 @@ endif
# Help text used by make help
help:
@echo ' config - Update current config utilising a line-oriented program'
+ @echo ' nconfig - Update current config utilising a
ncurses menu based program'
@echo ' menuconfig - Update current config utilising a menu based program'
@echo ' xconfig - Update current config utilising a QT based front-end'
@echo ' gconfig - Update current config utilising a GTK based front-end'
@@ -127,8 +131,8 @@ check-lxdialog :=
$(srctree)/$(src)/lxdialog/check-lxdialog.sh