[PATCH 1/7]: PCI revised (2) [PATCH 16/42]: PCI: PCI Error reporting callbacks

[PATCH 1/7]: PCI revised (2) [PATCH 16/42]: PCI: PCI Error reporting callbacks

Post by Greg K » Wed, 09 Nov 2005 06:41:58



Closer but...


You don't have to use an enum anymore, just use a #define.

Sparse developers, I see code in the kernel that that does both
(__force foo_t) and (foo_t __force). Which one is correct?



Ugh, I don't like that name, but I can't think of anything better right
now. You should at least keep "pci" at the beginning to make it make
more sense to people looking at it for the first time.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH 1/7]: PCI revised (2) [PATCH 16/42]: PCI: PCI Error reporting callbacks

Post by Greg K » Wed, 09 Nov 2005 08:00:23


Good point.


Ok, thanks for clearing this up.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/