[NFS] [PATCH] knfsd: Correct reserved reply space for read requests.

[NFS] [PATCH] knfsd: Correct reserved reply space for read requests.

Post by Neil Brow » Tue, 04 Apr 2006 10:20:07



Maybe... but why not 128K ??

There is certainly room to increase NFSSVC_MAXBLKSIZE, but I feel that
it needs to be done together with a more detailed look at consequences
in the network layer, particularly TCP window sizes. I wouldn't mind
making a CONFIG_ tunable without that detailed look, but making it a
fixed change I feel less comfortable about.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[NFS] [PATCH] knfsd: Correct reserved reply space for read requests.

Post by Marc Eshe » Tue, 04 Apr 2006 12:40:10


XXXX@XXXXX.COM wrote on 04/02/2006 06:17:17 PM:


64K to
(we

Yes, It would be nice to be able to match the Linux client side that can
go to 1MB.


Like you said it will need match more work to do it right and also not
waste space for all RPC request to which the maximum possible size is
allocated up front. But until than way not take advantage of this minor
change that can give us significant performance improvement. I run with
NFSSVC_MAXBLKSIZE set to 64K (the only change I made) and saw 10%-15%
improvement for NFS reads. Is there anyone out there that is looking at
making this improvement ?

Marc.

language
webcast
territory!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

[NFS] [PATCH] knfsd: Correct reserved reply space for read requests.

Post by Neil Brow » Tue, 04 Apr 2006 12:50:06


It was a fairly soft reservation of space, and we never actually tried
to use it all.
I don't see a clear problem with just making the change you mention,
but until I have thought through the implications (or until someone
else has and convinces me) I don't feel comfortable making the change.

It's on my todo list, but that doesn't promise a lot :-(
If someone else wants to try to convince me it is safe, and mention
tcp window sizes a couple of time, I'll probably be happy with it.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/