[PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options

[PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options

Post by Pekka J En » Tue, 07 Mar 2006 16:40:10


Hi Phillip,



Formatting.


Same here.


This is better, but if id was -1 on disk, we're overriding it unless the
forget mount option was specified. Do we want that? I think my patch is a
better fix (if it works anyway) and yours should be on top of that. Did
you have the chance to test it?

Also, formatting is, wrong, just make it

if (forget)
fe->uid = ...;
else
fe->uid = ...;


Same here.

Please document the new mount options in Documentation/filesystems/udf.txt.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/
 
 
 

[PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options

Post by Pekka J En » Wed, 08 Mar 2006 16:30:17


Looks like you're using two spaces. Indentation is one tab and one tab is
exactly eight characters (see Documentation/CodingStyle).



Okay, fair enough. I see akpm has taken your patch. Please make sure the
mount options are documented. Thanks!

(Please note that we didn't fix the unconditional memset now, so there's
dead code in udf_update_inode(). The check for TAG_IDENT_USE will always
fail.)

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/

 
 
 

[PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options

Post by Andrew Mor » Tue, 21 Mar 2006 13:10:09


I didn't see that update, and I don't miss much.


This is an unchangelogged alteration.

Please provide a description of this change. What problem is it fixing?
How does it fix it? What are the consequences of not making this change?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to XXXX@XXXXX.COM
More majordomo info at http://www.yqcomputer.com/
Please read the FAQ at http://www.yqcomputer.com/