Question regarding Shared Functions or Subs

Question regarding Shared Functions or Subs

Post by Patrio » Wed, 22 Nov 2006 08:45:00


I wonder if it is threadsafe to have a Shared Function or Sub like
this:

Public Class Data1
Public Shared Function Query1(Byref sCnxn as String, Byval sSql As
String) As DataTable
Dim oCnxn As New SqlConnection(sCnxn)
Dim oCmd As New SqlCommand(sSql, oCnxn)
Dim oDs As New DataSet

' Mark the Command as a SPROC
oCmd.CommandType = CommandType.Text

oCnxn.Open()
Dim oDa As SqlDataAdapter = New SqlDataAdapter(oCmd)
oDa.Fill(oDs, "result")

oCmd.Dispose()
oCnxn.Close()

Dim dt As DataTable = oDs.Tables("result").Copy
oDs.Clear()
oDs = Nothing
oDa = Nothing

Return dt
End Function
End Class

Will I have any problem with multiple concurrent web requests?

Thanks
 
 
 

Question regarding Shared Functions or Subs

Post by Mattias Sj » Wed, 22 Nov 2006 15:14:53

>Will I have any problem with multiple concurrent web requests?

I don't tnhink so, you're not using any shared state as far as I can
see.


Mattias

--
Mattias Sjren [C# MVP] mattias @ mvps.org
http://www.yqcomputer.com/ | http://www.yqcomputer.com/
Please reply only to the newsgroup.

 
 
 

Question regarding Shared Functions or Subs

Post by Patrio » Thu, 23 Nov 2006 02:48:11

Thank you for your feedback Mattias.

I was a bit worried that the connection will be closed unexpectedly. I
guess it'll be alright since none of the variables or parameters are
shared.

Thanks again.

On Nov 20, 10:14 pm, Mattias Sjren